argon-design-system icon indicating copy to clipboard operation
argon-design-system copied to clipboard

[Bug] Navbar collapse animation

Open Pioooooo opened this issue 5 years ago • 5 comments

Version

1.0.1

Reproduction link

https://demos.creative-tim.com/argon-design-system/docs/components/navbar.html

Operating System

Windows

Device

PC

Browser & Version

Firefox 81.0.2

Steps to reproduce

opne the page on a small screen like 320x480, click the collapse botton on the navbar to open it and then click on the x botton to close it

What is expected?

there should be a same animation when collapsing it just like expanding

What is actually happening?

the card keeps showing for a while before it suddenly dissappear


Solution

Additional comments

checking the style.css, I found there is a collapsing-out class which should be and is not used when collapsing the navbar. js should be modified or simply use the default bootstrap transition

Pioooooo avatar Oct 19 '20 06:10 Pioooooo

Hi @Pioooooo,

Thank you for working with our products.

Can you please me a short video to see clearly what happens on your device? I tried now and it seems to work fine on our side.

Thank you, Rares

rarestoma avatar Oct 19 '20 06:10 rarestoma

I click instantly after opening the panel but it wait for 2sec before it close

2020-10-19 14-54-12.zip

Pioooooo avatar Oct 19 '20 06:10 Pioooooo

navbar-collapse

Hi @Pioooooo I think you want to have the same animation on both opening and closing of mobile nav:) Is its the case?

@rarestoma

Best Regard, Sajad

sajadevo avatar Oct 23 '20 15:10 sajadevo

Hi @SajadAhmadNawabi That's it. Forgive my poor english and manner 0.0

Best Regard, Pio

Pioooooo avatar Oct 23 '20 15:10 Pioooooo

@Pioooooo So there's no animation for closing of mobile nav but, you can add a simple transition for it by your own:)

Thank you, Sajad

sajadevo avatar Oct 24 '20 07:10 sajadevo