feat(bash-completion): prevent space after profile completion `.`
When tab completing a profile, an unwanted space is added after the period ., necessitating hitting backspace before further completions can be accessed.
The implementation here was based on the following resources:
- https://stackoverflow.com/a/66151065
- Add spaces to the end of some Bash autocomplete options, but not to others?
- https://stackoverflow.com/a/19271994
- How can I check the last character in a string in bash?
An alternative to checking for the last character is using regex:
- https://stackoverflow.com/a/21425089
- How to check if the last string character equals '*' in Bash?
Walkthrough
The changes involve modifications to the Bash completion function for resticprofile. A new conditional check is introduced to determine if the last character of the COMPREPLY array is a period. If not, the compopt +o nospace command is executed, enabling the insertion of a space after completion suggestions. Additionally, the completion registration for resticprofile is updated to directly include the -o nospace option, ensuring consistent completion behaviour.
Changes
| Files | Change Summary |
|---|---|
| contrib/completion/bash-completion.sh | Updated _resticprofile function to add a conditional check for a period at the end of COMPREPLY and modified the complete command to include -o nospace. |
Sequence Diagram(s)
sequenceDiagram
participant User
participant Shell
participant _resticprofile
User->>Shell: Request completion for resticprofile
Shell->>_resticprofile: Call _resticprofile function
_resticprofile->>_resticprofile: Check last character of COMPREPLY
alt Last character is not a period
_resticprofile->>Shell: Execute compopt +o nospace
end
_resticprofile->>Shell: Return completion suggestions
Shell->>User: Display completion suggestions
π Recent review details
Configuration used: CodeRabbit UI Review profile: CHILL
π₯ Commits
Files that changed from the base of the PR and between f47f40882108767570755447c65dbe4d4f766b72 and cc68b183144ab25786e4d00a0eabebafccb3e683.
π Files selected for processing (1)
- contrib/completion/bash-completion.sh (1 hunks)
π§ Files skipped from review as they are similar to previous changes (1)
- contrib/completion/bash-completion.sh
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
πͺ§ Tips
Chat
There are 3 ways to chat with CodeRabbit:
- Review comments: Directly reply to a review comment made by CodeRabbit. Example:
I pushed a fix in commit <commit_id>, please review it.Generate unit testing code for this file.Open a follow-up GitHub issue for this discussion.
- Files and specific lines of code (under the "Files changed" tab): Tag
@coderabbitaiin a new review comment at the desired location with your query. Examples:@coderabbitai generate unit testing code for this file.@coderabbitai modularize this function.
- PR comments: Tag
@coderabbitaiin a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.@coderabbitai read src/utils.ts and generate unit testing code.@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.@coderabbitai help me debug CodeRabbit configuration file.
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.
CodeRabbit Commands (Invoked using PR comments)
@coderabbitai pauseto pause the reviews on a PR.@coderabbitai resumeto resume the paused reviews.@coderabbitai reviewto trigger an incremental review. This is useful when automatic reviews are disabled for the repository.@coderabbitai full reviewto do a full review from scratch and review all the files again.@coderabbitai summaryto regenerate the summary of the PR.@coderabbitai resolveresolve all the CodeRabbit review comments.@coderabbitai configurationto show the current CodeRabbit configuration for the repository.@coderabbitai helpto get help.
Other keywords and placeholders
- Add
@coderabbitai ignoreanywhere in the PR description to prevent this PR from being reviewed. - Add
@coderabbitai summaryto generate the high-level summary at a specific location in the PR description. - Add
@coderabbitaianywhere in the PR title to generate the title automatically.
CodeRabbit Configuration File (.coderabbit.yaml)
- You can programmatically configure CodeRabbit by adding a
.coderabbit.yamlfile to the root of your repository. - Please see the configuration documentation for more information.
- If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation:
# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json
Documentation and Community
- Visit our Documentation for detailed information on how to use CodeRabbit.
- Join our Discord Community to get help, request features, and share feedback.
- Follow us on X/Twitter for updates and announcements.
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 72.30%. Comparing base (
4181d9e) to head (cc68b18). Report is 1 commits behind head on master.
Additional details and impacted files
@@ Coverage Diff @@
## master #405 +/- ##
=======================================
Coverage 72.30% 72.30%
=======================================
Files 127 127
Lines 12940 12940
=======================================
Hits 9356 9356
Misses 3158 3158
Partials 426 426
| Flag | Coverage Ξ | |
|---|---|---|
| unittests | 72.30% <ΓΈ> (ΓΈ) |
Flags with carried forward coverage won't be shown. Click here to find out more.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.