wp-plugin-creativecommons icon indicating copy to clipboard operation
wp-plugin-creativecommons copied to clipboard

Published 20 hours ago • verified publisher icon creativecommons

Change some text for CC0 image attribution

Open siccovansas opened this issue 5 years ago • 6 comments

Description

When I go to my WordPress Media page and add a CC0 license to an image the generated license text for that image is:

Except where otherwise noted, the content on this site is licensed under a CC0 1.0 Universal License.

Shouldn't it be something like:

Except where otherwise noted, this media is licensed under a CC0 1.0 Universal License.

And maybe the "Except where otherwise noted, " should be removed as well when licensing media?

Reproduction

  1. Add a CC0 license to media
  2. See text

Expectation

Expect text specifying that the license only holds for that image instead of the whole site.

Environment

  • Browser: Firefox 81.0.2
  • Version: v2020.09.1

siccovansas avatar Oct 28 '20 14:10 siccovansas

Hello, I have a good hand on wordpress plugin development and customization. But almost no with open source, I want to fix this particular issue. Can u please explain a bit more, how I can reproduce this behaviour, I tried to add license in media library, also I added that to a post. But couldn't find attribution text. Please let me know, how I can check the issue?

ankitmishra88 avatar Nov 08 '20 07:11 ankitmishra88

Hi @siccovansas, can you please elaborate on what text are you exactly talking about? I added a license to a image and I could see no text generated.

Unnamed

nishantwrp avatar Feb 26 '21 12:02 nishantwrp

Hi @nishantwrp, the text I get is generated by the license_html_rdfa function which I call in a script to add the license to media.

siccovansas avatar Feb 26 '21 14:02 siccovansas

Hi, I still can't get how this function is used to generate licenses for media. Can you please maybe provide some steps/screenshots to reproduce this error?

nishantwrp avatar Mar 01 '21 07:03 nishantwrp

@nishantwrp you can find the code in which we call the license_html_rdfa function here: https://github.com/openstate/open-state-theme-2019/blob/94ff57a84377c34376f39aa793e57b9c0e0c4d08/app/filters.php#L155-L270

siccovansas avatar Mar 03 '21 09:03 siccovansas

Hi @siccovansas, actually that function is used in this plugin to generate_rdfa on the complete site i.e. by footer or widget. I don't think there is such function for image attributes (@hugosolar please confirm). However, I think you can do something like

https://github.com/creativecommons/wp-plugin-creativecommons/blob/ce7e1ce14e6718fc2c44ef876eadaa691b58700f/src/CC-BY-CC0/block.js#L91-L96

nishantwrp avatar Mar 04 '21 06:03 nishantwrp