og-image-generator icon indicating copy to clipboard operation
og-image-generator copied to clipboard

Image backgrounds

Open zackkrida opened this issue 5 years ago • 12 comments

The app should support full image backgrounds, ideally sourced from https://search.creativecommons.org. Because this is CC, we need to show an attribution for each image as well.

~We could, for now, allow users to add an image url + manually add an attribution.~

I no longer think it makes sense to add special support for cc search, but a feature for image backgrounds would be excellent. This should add a few settings:

  • A dropdown for background type (choices are pattern | image) that defaults to pattern
  • A text input for the image url
  • A field to add attribution to the image (this is essential for Creative Commons) which can just be a textarea. We can include a link to https://chooser-beta.creativecommons.org/ in the field description so users can generate an attribution there and paste it in.

The attribution should display in a black box at the bottom of the card, like on this image

zackkrida avatar Oct 13 '20 18:10 zackkrida

can i do this ?

CadencePrestissimo avatar Oct 30 '20 07:10 CadencePrestissimo

@zackkrida Can I work on this? I am new to this so it would be great if you could guide me in what files to look to solve this issue

2001asjad avatar Jan 04 '21 10:01 2001asjad

Is this issue still open to take? if yes, then can I take it? I am new, so kindly let me know the files to work on

mmkm10 avatar Jan 04 '21 12:01 mmkm10

@2001asjad and @mmkm10 thank you for your interest. Zack won't be available until the week of Monday 1/18.

Also given that this CC Search is now in maintenance mode (see Upcoming Changes to the CC Open Source Community — Creative Commons Open Source), this feature will probably focus on allow users to add an image url + manually add an attribution

TimidRobot avatar Jan 06 '21 18:01 TimidRobot

Is this issue open to work? Can I take this?

mmkm10 avatar Feb 05 '21 12:02 mmkm10

Hi @mmkm10, yes this is open, and @TimidRobot is correct in their comments.

I don't think it makes sense to add special support for cc search, but a feature for image backgrounds would be excellent. This should add a few settings:

  • A dropdown for background type (choices are pattern | image) that defaults to pattern
  • A text input for the image url
  • A field to add attribution to the image (this is essential for Creative Commons) which can just be a textarea. We can include a link to https://chooser-beta.creativecommons.org/ in the field description so users can generate an attribution there and paste it in.

The attribution should display in a black box at the bottom of the card, like on this image

Let me know if you have any questions! Thanks.

zackkrida avatar Feb 05 '21 17:02 zackkrida

Hello, Is this issue still open? I would like to work on this one.

CapriciousRebel avatar Feb 16 '21 11:02 CapriciousRebel

@CapriciousRebel Sure, all yours! Let me know if you need any help

zackkrida avatar Feb 17 '21 00:02 zackkrida

@zackkrida I'll start work on this issue immediately. Kindly assign this issue to me

CapriciousRebel avatar Feb 20 '21 00:02 CapriciousRebel

can I work upon this issue?

Gulshanaggarwal avatar Feb 22 '21 14:02 Gulshanaggarwal

@Gulshanaggarwal I'm currently working on this issue and will make a pr today itself, I'd suggest you work on another open issue... (edit) here is the draft PR: https://github.com/creativecommons/og-image-generator/pull/20

CapriciousRebel avatar Feb 23 '21 02:02 CapriciousRebel

@zackkrida I would sincerely appreciate your inputs on the following questions:

  • As requested, I added a dropdown for background type, text input for image URL, and a text area for the attribution, using classes sourced from https://cc-vocabulary.netlify.app/
  • The attribution generated from chooser will look something like "my work by me is licensed under CC BY 4.0".
  • As suggested in the image provided it should be trimmed down to "my work by me".
  • This can be achieved simply by using the inputs from the attribution field.
  • I wanted to know what is to be done with the inputs received from the background-type and the image-url fields.
Screenshot 2021-02-24 at 4 44 48 PM

CapriciousRebel avatar Feb 23 '21 05:02 CapriciousRebel