creativecommons
[Bug] CSS Link Tag Does Not Follow Vocabulary Documentation
Description
The <link> tag for the CSS file is missing the media attribute, which is required for proper HTML semantics.
And this does not follow the vocabulary docs. In the vocabulary docs, link tag for stylesheets must have the media="all".
Reproduction
- Clone the repo and go to
base.htmlin scholarship folder - Observe that the
<link>tag for the CSS file does not include a media attribute:- https://github.com/creativecommons/legaldb/blob/83e0303b56e2a97b6fefd627bb049b9dd380b028/legal_db/templates/legal_db/base.html#L12
- See error.
Expectation
The link tag for stylesheet should have the media="all" as stated in Vocabulary documentation.
Additional context
- creativecommons/vocabulary: A cohesive system of design for Creative Commons
Resolution
- [ ] I would be interested in resolving this bug.
Hello, I am an Outreachy applicant, I would like to work on this.
hi @bhekidaweti , I hope you're doing okay. You can indicate your interest in an issue by opening a pull request with your own solution for the issue. However, any issue that you open a PR for must have the ready for work label. I hope this helps clarify things for you and I hope you have a good time contributing to this project.
Please see Contribution Guidelines — Creative Commons Open Source for how we manage issues and pull requests (PRs).
We generally don't assign issues prior to resolution. Instead of asking for issues to be assigned, do the work and submit a PR. Even if multiple people submit PRs for the same issue, multiple ideas and implementations strengthen the final product.
For work program applicants, each can all list their own PRs on their application. It is the quality of work that is important, not whether it is merged.
