chooser icon indicating copy to clipboard operation
chooser copied to clipboard

[Feature] Error pages are not styled/themed

Open TimidRobot opened this issue 1 year ago • 10 comments

Problem

Error pages are not styled/themed

Current 404 page: Screenshot 2024-04-24 at 11-47-50 Page not found · GitHub Pages

Description

The error pages should not disrupt the user experience

  • error pages should be a resource lite as possible
    • (this issue mustn't be solved with Legacy (Vue) Vocabulary)
  • error pages should be should be styled/themed (without being "heavy").
  • creativecommons/vocabulary#1

Alternatives

Do nothing

Additional context

Implementation

  • [ ] I would be interested in implementing this feature.

TimidRobot avatar Apr 24 '24 18:04 TimidRobot

@TimidRobot I would be interested in implementing this feature. , could you please assign this to me

akshansh-modi avatar Jun 18 '24 13:06 akshansh-modi

@TimidRobot I would be interested in implementing this feature. , could you please assign this to me

@akshansh-modi Please see Contribution Guidelines — Creative Commons Open Source for how we manage issues and PRs.

We generally don't assign issues prior to resolution. Instead of asking for issues to be assigned, do the work and submit a pull request (PR). Even if multiple people submit PRs for the same issue, multiple ideas and implementations strengthen the final product.

TimidRobot avatar Jun 18 '24 14:06 TimidRobot

hey @TimidRobot I want to contribute to this issue , could you assign me this issue

ankur-kalita avatar Aug 03 '24 05:08 ankur-kalita

hello ! actually i want some help from you to start the project and how to start . i am the beginner and i am trying to do projects . but by some queries , i won't make it. can you please help me as a mentor?

kritika-76 avatar Aug 29 '24 07:08 kritika-76

@TimidRobot How about this page?

https://github.com/user-attachments/assets/c08c544e-ff71-4635-99eb-b8a0776f8524

saikatsardar01 avatar Oct 08 '24 08:10 saikatsardar01

If you like it I can give a pull request

saikatsardar01 avatar Oct 08 '24 08:10 saikatsardar01

@TimidRobot @possumbilities I was doing research on the implementation of this.

Could this be implemented upstream in the vocabulary repository. The reason for this thinking is as follows;

  • All CC ancilliary sites don't have a uniform error page implementation.
  • All sites have the same class of errors that could occur (i.e 4xx, 5xx etc), hence a design system can effectively accomodate these variations.

While a PR can be submitted for this specifically for this issue, I think it would be a great opportunity to standardize the error page structure.

Here is how I would go about it;

  1. Implement the error page styles in the vocabulary repository, along with creating a specimen in the context folder, to visaulize the error page, collaborating with project maintainers for feedback.
  2. Update the vocabulary version of the chooser repo to reflect the error styles update
  3. Implement the error page in the chooser repo, following the approved design system arrived at in step 1.

Please let me me know what you think about this.

egbadon-victor avatar Nov 05 '24 14:11 egbadon-victor

@TimidRobot I have raised a pr for this issue , would like your review for this . Thanks

kris70lesgo avatar Jan 12 '25 10:01 kris70lesgo

@egbadon-victor I like your approach, and I think its worth pursuing!

I believe you created a duplicate issue on the vocabulary repo here:

  • https://github.com/creativecommons/vocabulary/issues/306

The original Issue:

  • https://github.com/creativecommons/vocabulary/issues/1

I think it still worth pursuing as a means to solve the original Issue, and then apply changes downstream here and other places. I'd suggest you move work to the Vocabulary repo and submit a PR against https://github.com/creativecommons/vocabulary/issues/1 to accomplish that.

possumbilities avatar Jan 15 '25 15:01 possumbilities

hello @possumbilities , I am a beginner and unsure why this is happening. Can you provide some concise advice to help me understand where I might be going wrong?

Image

AbhayPundora avatar Jan 18 '25 03:01 AbhayPundora