cc-legal-tools-app icon indicating copy to clipboard operation
cc-legal-tools-app copied to clipboard

[Feature] Refactor ns (ccREL namespace) template as HTML5+RDFa

Open TimidRobot opened this issue 1 year ago • 11 comments

Problem

The ccREL namespace (templates/ns.html) template is currently XHTML+RDFa and does not match rest of site (ex. missing header & footer). It is currently a standalone template.

Description

  • Refactor ccREL namespace (templates/ns.html) template so that it:
    1. is HTML+RDFa (HTML 5) instead of XHTML+RDFa (XHTML 4)
    2. extends the base (templates/base.html) template (so that the ccREL namespace page includes the header & footer)
      • This is OPTIONAL as it might signficantly increase the scope of work. If changes to the base template are required, then every template that extends it needs to be checked/verified.

Alternatives

Do nothing

Additional context

TimidRobot avatar Nov 28 '23 23:11 TimidRobot

Hi @TimidRobot , I understand this issue, I would like to work over this. Thankyou

pushkar707 avatar Feb 04 '24 06:02 pushkar707

This is how the page looks after extending it to base.html. The layout have changed a bit, but I think it looks better. Is this acceptable: image

pushkar707 avatar Feb 04 '24 07:02 pushkar707

This is the code after changes:-

{% extends 'base.html' %}

{% block title %}Describing Copyright in RDF - Creative Commons Rights Expression Language{% endblock %} {% block head_meta %} {% endblock %}

{% block title_header %}

Creative Commons

{% endblock %}

{% block content %}

{% endblock %}

pushkar707 avatar Feb 04 '24 07:02 pushkar707

hi @TimidRobot, can you please check the above comment and screenshot by me and let me know!

Thankyou

pushkarDigitWork avatar Feb 23 '24 17:02 pushkarDigitWork

@pushkar707 & @pushkarDigitWork I would rather review any changes in a Pull Request (PR) instead of as comments on issues

TimidRobot avatar Feb 26 '24 18:02 TimidRobot

hey @TimidRobot This is Balraj, I want to work on this issue, can you please tell me what specifically you want to get updated or get fixed.

BalrajDhakad avatar Mar 01 '24 13:03 BalrajDhakad

Please see Contribution Guidelines — Creative Commons Open Source for how we manage issues and PRs (we generally don't assign issues prior to resolution).

TimidRobot avatar Mar 01 '24 18:03 TimidRobot

I have already read it but I am not able to get what do you want to say about assigning this issue to me @TimidRobot

BalrajDhakad avatar Mar 01 '24 18:03 BalrajDhakad

@BalrajDhakad If you have followed the guidelines above, you don't need to ask permission to start work on an issue.

ShivamAhir avatar Mar 07 '24 10:03 ShivamAhir

@ShivamAhir I have already read the guidelines above and I am already a contributor in CC, please don't mind my words but I am not asking permission to start working on this issue, I am simply asking for more details related to this issue. You will get it if you will read my last third comment on this issue.

BalrajDhakad avatar Mar 07 '24 12:03 BalrajDhakad

I am simply asking for more details related to this issue.

I updated the description

TimidRobot avatar Mar 08 '24 15:03 TimidRobot