bbb-download icon indicating copy to clipboard operation
bbb-download copied to clipboard

mp4 not generated for some rebuilds

Open akhtarkamal1-ed opened this issue 5 years ago • 3 comments

Hello

For new recordings of short duration the mp4 is created.

Did a Rebuild on an existing BBB recording and the mp4 was not generated.

Looked into /var/log/bigbluebutton/download/meetingid.log

Looked liked the log had what FFmpeg was trying to do when converting the recording and here is the error at the end of the log.

bbb_version: 2.1.0 Traceback (most recent call last): File "/usr/local/bigbluebutton/core/scripts/post_publish/download.py", line 288, in main() File "/usr/local/bigbluebutton/core/scripts/post_publish/download.py", line 267, in main dictionary, length, dims = prepare(bbb_version) File "/usr/local/bigbluebutton/core/scripts/post_publish/download.py", line 183, in prepare dictionary, length = extract_timings(bbb_version) File "/usr/local/bigbluebutton/core/scripts/post_publish/download.py", line 57, in extract_timings temp = float(out_times[len(out_times) - 1]) ValueError: could not convert string to float:

Would appreciate if you could point in the right direction.

akhtarkamal1-ed avatar Aug 13 '20 09:08 akhtarkamal1-ed

Hi - I am also facing the same problem

edunova avatar Sep 30 '20 18:09 edunova

You can fix this problem with this patch:

diff --git a/src/download.py b/src/download.py
index 2f73e68..77aa654 100644
--- a/src/download.py
+++ b/src/download.py
@@ -54,6 +54,9 @@ def extract_timings(bbb_version):
         in_times = str(image.getAttribute('in')).split(' ')
         out_times = image.getAttribute('out').split(' ')
 
+        if not in_times[len(in_times) - 1] or not out_times[len(out_times) - 1]:
+            continue
+
         temp = float(out_times[len(out_times) - 1])
         if temp > total_length:
             total_length = temp

sydro avatar Mar 18 '21 15:03 sydro

or change: temp = float(out_times[len(out_times) - 1])

with:

try:
      temp = float(out_times[len(out_times) - 1])
 except:
     continue

rmuzzini avatar Mar 30 '21 13:03 rmuzzini