M. J. Fromberger

Results 100 comments of M. J. Fromberger

❌ I decided not to merge #54, cf. https://github.com/creachadair/jrpc2/pull/54#issuecomment-925068474 for context. I recommend using the workaround from https://github.com/creachadair/jrpc2/issues/46#issuecomment-919448382 for any cases where the two types need to be used similarly.

✅ Move command-line tools to a separate module (f3f3c4c3). ✅ `server`: Make the listener interface easier to implement (31ce9d5f). ✅ Add support for dynamic metric labels (55fbb9bc). ✅ Replace `DataErrorf`...

✅ Support positional arguments in the `handler` package (#59). ✅ Remove support for variadic functions in the `handler` package (47802359). ✅ Simplify and generalize the text logger interface (bfa778d1).

Consider removing the `AllowV1` server and client options. The intent of this option was to tolerate calls to/from [JSON-RPC 1.0](https://www.jsonrpc.org/specification_v1) implementations, but that alone isn't enough for interoperability. For example...

Remove the server-side CheckRequest hook. I added this as a place to hook in auth checks, but the value of having the server handle this (vs. deferring to the Handler)...

Remove the parameter-wrapping context plumbing hooks. This was meant as a transparent way to encode context settings, but it was a lot of overhead for relatively little use. ✅ #82

Replace the custom metrics collector plumbing with the standard `expvar` package. This will make it easier to export metrics to more conventional collectors like Prometheus. ✅ #89

The consensus node does not publish events for unconfirmed transactions added to the mempool. `Tx` events are generated after delivery, when a block is committed. There is a separate call...

> What's the query, can't find. https://docs.tendermint.com/v0.34/rpc/#/Info/unconfirmed_txs

We specifically did not want to use a different name for the macro, since there does not seem to be any way to change the type of an existing rule...