Ulrich Hornung

Results 72 comments of Ulrich Hornung

@cakebaker, @tertsdiepraam, @sylvestre - please review

What is missing is a review and approval from one of the maintainers. @sylvestre - I also did the squash commit now. Let me know what you think.

> One final question: have you seen any intermittently failing tests with this? Can we assume that this implementation is robust enough not to make our test suite fail unexpectedly...

The documentation of fs::copy states explicitly that any file at destination will be overwritten. So its not needed for us to delete the file explicitly before. But we could remove...

@samueltardieu Thanks for providing your results. I'm still on the way to setup a virtual android device. I figured out that the issue with the "test_head" was fixed meanwhile on...

> You can also use your phone and drive it with [scrcpy](https://github.com/Genymobile/scrcpy) which is an absolute delight to work from the computer on a real device. That's what I did....

it runs now somehow. I still have the error, but it seems to be sporadically and randomly. When I re-run the build it gets further than before. If I repeat...

I'm failing to get a remote debugging running. Have you ever tried this? Do you have recommendations?

@samueltardieu: I pushed some more changes to make all the tests green for me. Can you confirm? @sylvestre: I think this pull request is at a state acceptable for merging....