Cody Crewson

Results 87 comments of Cody Crewson

@lucserre Can we start with the basics, - Do you have a dataset you can share? - Could you also share the commands you used to convert the dataset? -...

Thank you, the samples are a huge help @pchlap I can see two ways of accomplishing this from the point in the code you suggested. 1. Add a flag and...

I just submitted PR #1637 as an expedient solution to this problem. I do intend to properly refactor the code, but felt that @lucserre has been waiting too long.

> Hi @lucserre, > > > > The PR with this fix is over at: > > > > ![image](https://user-images.githubusercontent.com/6559099/171171089-e23a89a1-c019-49f6-8950-3f188359e7a7.png) > > > > When you go there you can...

> @crcrewso would you be interested in submitting a PR for a fix? @pchlap would you be able to review this one? When I get a fix of course I'll...

> > Though I doubt I'm doing it the 'right' way. > > All good, the "right way" is often far more apparent after the road has been travelled. Looking...

My previous thoughts on this were't quite right. There appears to be a transformation matrix in the *.VolumeInfo file ``` VolumeDisplay ={ VolumeName = "Dose -- Trial_1"; LocalToWorldTransform ={ Data...

> Is there a suitable (no PHI) sample of the data that represents the issue at hand? (at least the text files involved) I haven't had time yet to manually...

> https://github.com/pymedphys/pymedphys/blob/66b89ead81b3a0d010b08466a70607df8b2f87f8/lib/pymedphys/_experimental/pinnacle/image.py#L175-L176 > > https://github.com/pymedphys/pymedphys/blob/cb34c992de8d442eced3385018a194364060092d/lib/pymedphys/_experimental/pinnacle/rtdose.py#L226-L227 I'll talk to @AndrewWAlexander since this swap goes back to his original code

> > https://github.com/pymedphys/pymedphys/blob/66b89ead81b3a0d010b08466a70607df8b2f87f8/lib/pymedphys/_experimental/pinnacle/image.py#L175-L176 > > > > https://github.com/pymedphys/pymedphys/blob/cb34c992de8d442eced3385018a194364060092d/lib/pymedphys/_experimental/pinnacle/rtdose.py#L226-L227 > > I'll talk to @AndrewWAlexander since this swap goes back to his original code I discussed this with @AndrewWAlexander. He doesn't...