gen-bundle-image: Add bundle as label to have bundle file as value

[praveenkumar]

After building the image using this lable we can identify which bundle ship with container image without extracting it.

$ skopeo inspect --authfile /home/prkumar/pull-secret --no-tags docker://quay.io/praveenkumar/podman-bundle:4.1.1
{
    "Name": "quay.io/praveenkumar/podman-bundle",
    "Digest": "sha256:0e9ba567738f1639fcaf7c368532dea59933e2bfd5c8db4f2d9540c371c1f9b2",
    "RepoTags": [],
    "Created": "2022-08-18T11:50:10.628039178Z",
    "DockerVersion": "",
    "Labels": {
        "bundle": "crc_podman_libvirt_4.1.1_amd64.crcbundle",
        "io.buildah.version": "1.26.2"
    },
    "Architecture": "amd64",
    "Os": "linux",
    "Layers": [
        "sha256:554b666c655e35321b370defa4448ac66507655a5eeb7b321d6b2faefd890fb8"
    ],
    "Env": [
        "PATH=/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin"
    ]
}

[openshift-ci[bot]]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please ask for approval from praveenkumar by writing /assign @praveenkumar in a comment. For more information see:The Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

[anjannath]

This'll provide a convenient way to get the full name of the included bundle, where do we plan to use it?

also it seems we can already know what bundle the image will have based on the name:tag podman-bundle:4.1.1 and the OS architecture?

[praveenkumar]

This'll provide a convenient way to get the full name of the included bundle, where do we plan to use it?

https://github.com/code-ready/crc/issues/3277

also it seems we can already know what bundle the image will have based on the name:tag podman-bundle:4.1.1 and the OS architecture?

Plan is to use the crc release for tag as part of bundle pull instead bundle version.

[anjannath]

Plan is to use the crc release for tag as part of bundle pull instead bundle version.

I am not against having this label, just wondering if the crc tag/version should be used as the tag for the image, since goal is also to decouple the bundle/image from the crc version?

[praveenkumar]

Plan is to use the crc release for tag as part of bundle pull instead bundle version.

I am not against having this label, just wondering if the crc tag/version should be used as the tag for the image, since goal is also to decouple the bundle/image from the crc version?

No, plan is decouple crc binary with bundle version not the other way.

[cfergeau]

Plan is to use the crc release for tag as part of bundle pull instead bundle version.

Can you share the details/discussions/conclusions around this plan? I'm not sure we ever reached a final decision on this, but this is still used as a justification for some incremental patches helping to reach this goal.

[praveenkumar]

Plan is to use the crc release for tag as part of bundle pull instead bundle version.

Can you share the details/discussions/conclusions around this plan? I'm not sure we ever reached a final decision on this, but this is still used as a justification for some incremental patches helping to reach this goal.

@cfergeau https://github.com/code-ready/crc/issues/3206#issuecomment-1154839207 (after this comments). Yes we didn't reach to final decision but it is incremental patch to reach the goal of independently use different bundle with a specific crc release.

[cfergeau]

but it is incremental patch to reach the goal of independently use different bundle with a specific crc release.

It is an incremental patch towards what is described in https://github.com/code-ready/crc/issues/3206#issuecomment-1154839207 , for which there is no final decision. Shouldn't we first have a clear idea where we are going before starting pushing patches? This would avoid some back and forth, potential reverts, ...

[praveenkumar]

but it is incremental patch to reach the goal of independently use different bundle with a specific crc release.

It is an incremental patch towards what is described in code-ready/crc#3206 (comment) , for which there is no final decision. Shouldn't we first have a clear idea where we are going before starting pushing patches? This would avoid some back and forth, potential reverts, ...

@cfergeau Sure, let's discuss it tomorrow team sync and plan it out. I will put hold on this PR till then.

/hold

[openshift-merge-robot]

@praveenkumar: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[praveenkumar]

/close

[openshift-ci[bot]]

@praveenkumar: Closed this PR.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.