crc icon indicating copy to clipboard operation
crc copied to clipboard

Info provided in telemetry

Open albfan opened this issue 8 months ago • 5 comments

Component

None

Is your enhancement related to a problem? Please describe

A quick search on data crc provides to telemetry:

pkg/crc/telemetry/telemetry.go
57:6:func setContextProperty(ctx context.Context, key string, value interface{}) {
65:2:	setContextProperty(ctx, "cpus", value)
69:2:	setContextProperty(ctx, "memory", value)
73:2:	setContextProperty(ctx, "disk-size", value)
77:2:	setContextProperty(ctx, "key", value)
81:2:	setContextProperty(ctx, "start-type", value)

Not sure if we provide something else

Describe the solution you'd like

can it be relevant to gather other info?

  • platform
  • OS
  • language
  • country

Describe alternatives you've considered

No response

Additional context

identify crc usages

albfan avatar May 15 '25 09:05 albfan

some work is supposed to be done:

client.Identify(&analytics.Identify{
  UserId: "51f1ea27-3054-4278-9122-ad020cb48e28",
  Traits: map[string]interface{}{
    "enable-cluster-monitoring": false,
    "enable-experimental-features": false,
    "network-mode": "user",
    "os": "windows",
    "os_edition_id": "Professional",
    "os_release_id": "2009",
    "proxy": false,
    "used_installer": true,
  },
})

most probably a mapping missed

albfan avatar May 15 '25 09:05 albfan

we are not allowed to collect Country, as this is regarded as PII. Perhaps the locality/locale is OK, as that influences the execution of some tools, like output.

gbraad avatar May 15 '25 12:05 gbraad

Indeed, locale might work.

Finally os, version,etc are collected on user, just some default mapping on amplitude shows "platform". It matches with our "os"

We have too: os_release_name, os_release_version, os_edition, os_edition_version can help to identify os flavours

os: linux
os_release_name: fedora
os_release_version: 9.5

os: windows
os_edition: Professional
os_edition_id: 2009

From there we can create reports and metrics

albfan avatar May 16 '25 08:05 albfan

I just start a PR on lang property. For me it would be:

es_ES

split and identify country and language is an option, so not sure if that goes against PII

albfan avatar May 16 '25 08:05 albfan

split and identify country and language is an option, so not sure if that goes against PII

If we identify the country then yes it might go against PII.

praveenkumar avatar May 21 '25 10:05 praveenkumar