crc
crc copied to clipboard
test: microshift: Don't force network-mode to 'user'
Filing this now so that we don't forget it when we have bundles with https://github.com/crc-org/snc/pull/797. This will be put on hold until this happens.
We want our testing to be as close as possible to what end-users will
experience. Changing network-mode
is a significant difference from the
default. With https://github.com/crc-org/snc/pull/797 fixed, we no longer
need to force it to user
.
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please ask for approval from cfergeau. For more information see the Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve
in a comment
Approvers can cancel approval by writing /approve cancel
in a comment
/hold
@cfergeau: The following tests failed, say /retest
to rerun all failed tests or /retest-required
to rerun all mandatory failed tests:
Test name | Commit | Details | Required | Rerun command |
---|---|---|---|---|
ci/prow/e2e-microshift-crc | 9bae8e56d6576d46a679c379ce30ac27a90874d7 | link | true | /test e2e-microshift-crc |
ci/prow/integration-crc | 9bae8e56d6576d46a679c379ce30ac27a90874d7 | link | true | /test integration-crc |
ci/prow/e2e-crc | 9bae8e56d6576d46a679c379ce30ac27a90874d7 | link | true | /test e2e-crc |
Full PR test history. Your PR dashboard.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.
@jsliacan Can you try that and see if that works as expected.
PR needs rebase.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.