crc icon indicating copy to clipboard operation
crc copied to clipboard

extend the response from API to also send default value for config

Open anjannath opened this issue 2 years ago • 5 comments

Fixes #2869 e.g response for a single config cpus:

{
  "Configs": {
    "cpus": {
      "value": 2,
      "isDefault": true,
      "defaultValue": 2
    }
  }
}

Note: This will also need changes on the tray

anjannath avatar Apr 07 '22 12:04 anjannath

/retest

anjannath avatar Apr 11 '22 14:04 anjannath

/hold (needs changes on the tray side, before merging need to decide how we'll handle that)

anjannath avatar Apr 12 '22 04:04 anjannath

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Jun 12 '22 18:06 stale[bot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: To complete the pull request process, please ask for approval from anjannath after the PR has been reviewed.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci[bot] avatar Jun 14 '22 07:06 openshift-ci[bot]

@anjannath: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-crc fe33e1242253af1757e4b6433ce2fcad54329f16 link true /test e2e-crc

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

openshift-ci[bot] avatar Jun 14 '22 10:06 openshift-ci[bot]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Aug 13 '22 13:08 stale[bot]