add --embed-app=/path/to/folder option (or similar) for frankenphp

[henderkes]

or --build-frankenphp=/path/to/folder @crazywhalecc ?

[crazywhalecc]

I prefer --{with|build}-embed-app=/path/to/c-app, --{with|build}-frankenphp-app=/path/to/folder, --{with|build}-micro-app=/path/to/phar-or-php. WDYT?

And I personally don't use them anyway just because I don't want to wait repeated builds when embedding failure.

[henderkes]

Yes, that's a good idea to keep it in line with php conventions.

[henderkes]

The micro and frankenphp ones are fairly straightforward, but I'm not sure about embedded c apps, as we wouldn't be able to guess how they have to be built.

[crazywhalecc]

The micro and frankenphp ones are fairly straightforward, but I'm not sure about embedded c apps, as we wouldn't be able to guess how they have to be built.

Speaking of embed, I thought of a problem. If it is bin/spc-*-docker, these options are easy to be used incorrectly unless a relative path is used and it is in the source directory.

[henderkes]

Hmm, good catch. I don't think we can work around that, other than by copying the files/folder into the docker container before forwarding to bin/spc...

[crazywhalecc]

Another way is to use env vars to do it. In that way we could parse them in bin/spc-*-docker shell script and convert to absolute path, and automatically mount, pass.

[crazywhalecc]

For embed project, I don't have any idea and I think it's not appropriate to detect CMakeLists.txt or *.m4 by SPC. It fallbacks to our previous discussion.