react-native-splash-screen icon indicating copy to clipboard operation
react-native-splash-screen copied to clipboard

Possibly causing backward compatibility issues

Open Ibrahimsyah opened this issue 2 years ago • 1 comments

https://github.com/crazycodeboy/react-native-splash-screen/blob/b47197626804a742b8569cad50d5e0ed92fc765c/android/src/main/java/org/devio/rn/splashscreen/SplashScreen.java#L25

Those new code will replace the old Show(Activity activity, int themeResId) which will possibly causes bug after upgrading to 3.3.0 example Maybe it would be better to create a new Show method to handle the fullscreen instead of replacing the old one.

Ibrahimsyah avatar Dec 22 '21 07:12 Ibrahimsyah

Also, this change should have been considered a breaking change as 4.0.0

staltz avatar Feb 01 '22 12:02 staltz