react-native-splash-screen icon indicating copy to clipboard operation
react-native-splash-screen copied to clipboard

This dependency is affecting detox with RN 63

Open genesy opened this issue 5 years ago • 8 comments

https://github.com/wix/Detox/issues/2196 according to this issue on detox it's the dependency's fault that detox won't run properly.

genesy avatar Aug 13 '20 12:08 genesy

Solved by replacing splash-screen with react-native-bootsplash

sseppola avatar Aug 16 '20 07:08 sseppola

Thank you so much for reporting this. I was back and forth blaming Detox for not running properly.

lumberman avatar Sep 03 '20 21:09 lumberman

I can assure you, Detox “runs properly”. But I am impartial. 😛

LeoNatan avatar Sep 09 '20 03:09 LeoNatan

haha yeah i'm 100% sure that this is the splash-screen module's issue. the only way i resolved this is by conditionally removing this module when building for detox

genesy avatar Sep 09 '20 10:09 genesy

I can also confirm that this is causing an issue - removing the library and leaving everything else as-is fixes the detox issue

beverlyRoadGoose avatar Sep 15 '20 09:09 beverlyRoadGoose

any progress on this?

SplashScreen.hide() is not working when running with detox. We have to comment: // [RNSplashScreen show];, before doing any tests

zvs001 avatar Sep 22 '20 14:09 zvs001

Another workaround is to use [RNSplashScreen showSplash:@"LaunchScreen" inRootView:rootView]; instead of [RNSplashScreen show];

This will however impact the way the splash screen dismiss animation. The standard/system iOS fade-out animation of the splash screen will not be used with this approach and the splash screen view will be dismissed without any animation instead. But using this method RNSplashScreen will no longer use the technique...

    while (waiting) {
        NSDate* later = [NSDate dateWithTimeIntervalSinceNow:0.1];
        [[NSRunLoop mainRunLoop] runUntilDate:later];
    }

...to block the UI thread (and therefore to keep the native splash screen visible). This is apparently causing some issues with Detox.

mattijsf avatar Oct 30 '20 12:10 mattijsf

this is still an ongoing issue

dazlious avatar Oct 27 '22 19:10 dazlious