Antonio
Antonio
Nuked AstroidManager as suggested. Just waiting on your thoughts about exceptions preventing not found packages from being cached.
I made the search path part of its cache by converting it into a frozenset however there are lots of cache misses and the performance benefit gets nullified, so maybe...
Also since the main point of this PR (perf) may take a while, I can make a new PR to apply the nuking of the Astroid test class separately.
Yes, it seems like there are lots of calls for the same package with different paths which obliterates the cache. I collected all calls to find_spec with their arguments and...
I followed the suggestion and applied a similar change in pylint. Cache specs do improve a lot. Also it seems like previous tests were running with a polluted virtualenv so...
Nevermind about the frozenset, when converting it back to a list ordering is sometimes lost so it can't be used, at least not for the sensitive modpath, for the search...
Ooops , I changed the search paths to tuple as well. Perf is still good, in fact since most of the time we should be getting no search paths I...
Thanks to everyone as well for the help and reviews :handshake:
Thanks, I have rebased the MR and fixed the conflicts.
Thanks for the review, I have taken care of your observations.