docker-samba icon indicating copy to clipboard operation
docker-samba copied to clipboard

feat: support add groups for user

Open XiYang6666 opened this issue 6 months ago • 3 comments

XiYang6666 avatar Jun 21 '25 05:06 XiYang6666

Can you also add a new user with multiple groups in this file https://github.com/crazy-max/docker-samba/blob/master/test/data/config.yml so it's tested in ci workflow?

crazy-max avatar Jun 21 '25 13:06 crazy-max

auth:
  - user: foo
    group: foo
    uid: 1000
    gid: 1000
    password: bar
    groups: [qux, quux]
  - user: yyy
    group: xxx
    uid: 1100
    gid: 1200
    password_file: /tmp/yyy_password

group:
  qux: 2001
  quux: 2002

I think this is a better implementation because each user requires a main group. Additionally, this implementation can also ensure that groups are not created repeatedly.

XiYang6666 avatar Jun 21 '25 14:06 XiYang6666

Nice one! You spared me a MR with a more clumsy implementation Think will also be good to see the usage in examples here: https://github.com/crazy-max/docker-samba/tree/master/examples The entries added to readme do nothing useful in terms of samba shares from the same conf file

spaghetti-coder avatar Aug 27 '25 10:08 spaghetti-coder