diun icon indicating copy to clipboard operation
diun copied to clipboard

Application shutdown shouldn't fail healthchecks

Open com6056 opened this issue 4 months ago • 0 comments

Support guidelines

I've found a bug and checked that ...

  • [x] ... the documentation does not mention anything about my problem
  • [x] ... there are no open or closed issues that are related to my problem

Description

Right now, application shutdown triggers healthcheck failures which leads to notifications: https://github.com/crazy-max/diun/blob/e99c10917da848ab3397b5b5fa67e7cef3a58fa5/internal/app/diun.go#L196

This includes things like simply restarting diun, which probably shouldn't notify.

Expected behaviour

I would expect healthcheck failures to only trigger when there is an issue running diun (or when diun hasn't run in a certain amount of time, which healthchecks.io already handles for you).

Actual behaviour

healthchecks.io notifies you of a diun failure whenever you restart diun.

Steps to reproduce

  1. Restart diun
  2. Get a healthchecks.io failure notification

Diun version

v4.29.0

Docker info

N/A

Docker Compose config


Logs

Fri, 08 Aug 2025 23:53:28 UTC WRN Caught signal terminated

Additional info

No response

com6056 avatar Aug 09 '25 00:08 com6056