CrazyMax

Results 1192 comments of CrazyMax

Thanks for this PR but I think the error message to users should remain generic. You can still check what value is empty in the login step (expand `Run docker/login-action@v3`):...

> Curious question: the dist file are so large; how do you make sure that a malicious user didn't embed some nefarious content in it ? We have a scanner...

I think you should consider setting Docker tags you wish to retain as [semver](https://semver.org/) and use the `keepSemver` option instead. You can also use the `exclude` option to exclude tags...

I'm not sure I need to take a look but the preload script should take care of it: https://github.com/crazy-max/docker-dokuwiki/blob/0e8fa439dec6262ac149fdfff9a273678f53dd89/rootfs/tpls/preload.php#L3-L5

Right for plugins it seems we need to define `DOKU_PLUGIN`: https://github.com/splitbrain/dokuwiki/blob/eec187fc7de7a7a6186965736a2ccec9e95162be/inc/init.php#L32

Ok actually I forgot this was already taken into account so it should be fine: https://github.com/crazy-max/docker-dokuwiki/blob/0e8fa439dec6262ac149fdfff9a273678f53dd89/rootfs/etc/cont-init.d/03-config.sh#L82-L104 Will take a closer look when I can.

Looks like we forgot a compat check for https://github.com/moby/moby/actions/runs/8830465079/job/24245262993?pr=47683#step:12:2959 ``` === FAIL: frontend/dockerfile TestIntegration/TestCommandSourceMapping/worker=dockerd/frontend=builtin (5.31s) dockerfile_provenance_test.go:1183: Error Trace: /src/frontend/dockerfile/dockerfile_provenance_test.go:1183 /src/util/testutil/integration/run.go:94 /src/util/testutil/integration/run.go:208 Error: Received unexpected error: exporter "image" could not be...

@no23reason We got a similar report in https://github.com/docker/build-push-action/issues/1167. We are using the API to upload the build export artifact and we are not using zip format but gzip one: *...

@no23reason I made some changes in the toolkit to skip files that don't have the expected content-type before extracting them: https://github.com/actions/toolkit/compare/main...crazy-max:toolkit:test-skip-non-zip It seems to solve the issue. Here's a workflow...