CrazyMax

Results 1192 comments of CrazyMax

@lucacome > there's always a checkout in the job Not always. You can build a Docker image using a Git context so it does not require the checkout step. >...

@eine > It seems that the warning message is hidden from the users, which is misleading as it provides a false feeling of security. As seen in docker/login-action@adb7347/src/docker.ts#L36, on success...

@eine > Ideally developers/maintainers of Docker and GitHub Actions would communicate with each other for achieving a satisfactory solution. Maybe GitHub could simply install the [`pass` credential helper](https://www.passwordstore.org/) on the...

@eine @clarkbw actions/virtual-environments#2304 has been merged. Will be available ~January (https://github.com/actions/virtual-environments/issues/2302#issuecomment-749140395).

> I noticed that it affects the tag set in the image version and the order of which the tags are output. Yes `priority` affects tags order so image version...

@devinrsmith That could be done through `type=match` def but it's only supported for tags atm. Maybe also with #56.

@CAMOBAP You have this warning because you're using `type=semver`: https://github.com/metanorma/metanorma-docker/blob/abc2919a7793838262a48697931b4e267c3a56f0/.github/workflows/build-push.yml#L78-L84 ``` tags: | type=edge,branch=main type=ref,event=branch type=ref,event=pr type=semver,pattern={{version}} type=semver,pattern={{major}}.{{minor}} type=semver,pattern={{major}} ``` If your tag doesn't support semver and you just want...

> Isn't it better if the step will fail instead of the warning message? Yes maybe we could add a strict mode to the action for semver and maybe also...

> This would be insanely awesome. Would this also cover the situation of not having to set `cache-from` and `cache-to`? My understanding is that image layer caching by default is...