CrazyMax
CrazyMax
@ktock @jedevc Bake does not handle the context path hash like build (we just take the current work dir atm). This is also just specific to the k8s driver and...
Looks like this test fails: https://github.com/docker/buildx/actions/runs/4989923431/jobs/8934490857?pr=1803#step:4:581 ``` #17 67.71 === CONT TestReadTargetsWithDotCompose #17 67.71 bake_test.go:366: #17 67.71 Error Trace: /src/bake/bake_test.go:366 #17 67.71 Error: Not equal: #17 67.71 expected: "Dockerfile.webapp" #17...
> I'm not sure I understand the fix covered by TestReadTargetsWithDotCompose. `sanitizeTargetName` to convert `web.app` with `web_app` then merge targets with same resulting name, while those were distinct in compose...
> bake waits for Github Actions caches to be loaded before, and then it starts building images. Build will still run to retrieve image metadata and solve but when a...
This is an early draft. Provenance can be quite huge so we might need to set provenance only when the metadata file is requested.
Size of the metadata file can be quite huge for builds with many targets when using bake. We could either split each target to its own metadata file such as:...
@tonistiigi Updated to strip `buildConfig` and `metadata` from provenance if `BUILDX_METADATA_PROVENANCE` sets to `min`. Mode `max` sets full provenance. Let me know if defaulting to `min` would be good. Atm...
@dvdksn Forgot to add docs-followup label on this one 🙈 for `BUILDX_METADATA_PROVENANCE` env var that should be added in https://docs.docker.com/build/building/variables/#build-tool-configuration-variables
Thanks but I think this should be something done for all providers related to https://github.com/crazy-max/diun/issues/342
> I was just thinking that this won't dedupe across providers, but that's probably not an issue and also not nearly as easy since it appears that there is no...