hiera-gpg icon indicating copy to clipboard operation
hiera-gpg copied to clipboard

Apply some standard Ruby style conventions

Open dgoodlad opened this issue 12 years ago • 3 comments

Let me preface this: I normally hate whitespace commits/pull requests. However, there are some broadly accepted Ruby style conventions that I think are valuable to follow, if only to make it easier for other Ruby devs to contribute. Please feel free to disregard this PR if you don't agree :wink:

Doing a git diff --ignore-space-change lists only a few actual lines of diff, from revs c4e31fe and e8146db. The main whitespace change is 2-space soft tab indentation, which hides those two real changes since every line has been touched.

dgoodlad avatar Feb 02 '13 22:02 dgoodlad

:+1:

PS Github has a nice trick: w=1

https://github.com/crayfishx/hiera-gpg/pull/19/files?w=1

glennpratt avatar Feb 06 '13 16:02 glennpratt

@glennpratt right, nice call, thanks for linking straight to it too!

Now hopefully @crayfishx agrees with these changes :smirk:

dgoodlad avatar Feb 06 '13 21:02 dgoodlad

I was about to do the same, +1 to this. @crayfishx ?

dLobatog avatar Jul 12 '13 13:07 dLobatog