crater [Dark mode 🌑] Add a dark theme?

[Dark mode 🌑] Add a dark theme?

Open jramsgz opened this issue 4 years ago • 7 comments

After using this app I noticed that it lacks the feature of a dark mode and I thought it would be very cool to have one, would you be interested? I can send a PR for that (after 4.0 is released as it has a complete rewrite of the CSS) Also, where should I store the user settings for dark theme? (Database, local storage, ...)

Jun 10 '20 11:06 jramsgz

Hi @MakerLab-Dev,

Yes, a dark theme would be really great.. but its a lot of work in terms of design. Are you familiar with Figma?

How are you looking to work on this? will you be creating the design first or directly start working on styles?

Jun 19 '20 08:06 mohitpanjwani

I was thinking on using TailwindCSS theme feature, so that all the colors for dark mode can be changed from that file and (I think) that it won't take too much time to implement. No, I'm not familiar with Figma but I don't think we'll need it as it's just changing colors Tell me what you think about that and if you think there is another better approach

Jun 19 '20 10:06 jramsgz

Quick update here Looks like a dark mode variant is being developed by tailwind https://github.com/tailwindlabs/tailwindcss/releases#dark-mode-experimental I think that we could use that to make the dark mode of crater and be benefited from its simplicity and rapid development What do you think? @mohitpanjwani

Sep 06 '20 12:09 jramsgz

Hi @MakerLab-Dev yes that sounds great and its exactly what we were looking at for dark mode.

We can discuss that after this update is deployed :)

Sep 08 '20 06:09 mohitpanjwani

Great idea for the Dark mode! It should be easy to switch to dark mode now that there is tailwind in v4.