Custom fields always set as required

[MrLuFo]

Describe the bug When creating or editing a custom field, the field will always be a required field. It shows as a required field in the list and when creating a invoice, customer etc. with the field.

EDIT: In the database, is_required in table custom_fields has value 0 for the field in question, even though it still shows up as required in the ui.

Expected behavior If "Required" is not selected when creating a field, that field should be optional.

Screenshots

Please complete the following information:

• Crater version: 6.0.6
• PHP version: 7.4.3
• Database type and version: SQLITE 3.31.1

Optional info

• OS: Ubuntu 22.04 LTS
• Browser: Firefox, MS Edge

[mohitpanjwani]

I feel like this issue might be specific to SQLite DB but we are looking into it.

[khatriafaz]

@MrLuFo I tried to look into this, but I cannot reproduce the issue as specified.

The fields are working as expected. Tested with Mysql and SQLite databases. No issues.

[profiteroles1]

@MrLuFo I tried to look into this, but I cannot reproduce the issue as specified.

The fields are working as expected. Tested with Mysql and SQLite databases. No issues.

I can reproduce this easily. Every custom field we set is required. More crucially, the toggle state of every boolean custom field is not recorded, making custom fields themselves entirely pointless. Text fields are recorded initially, but when the customer or invoice is edited, the field is reset on submission.