crater
crater copied to clipboard
BAD currency layer Exchange rate API
currency_layer API links are incorrect. I've change the providers with the correct links. but I'm ashamed to say I don't know how to do a pull request. Basically, app/Models/ExchangeRateProvider.php $url = "https://api.apilayer.com/currency_data/live?apikey=".$request['key']."&source=INR¤cies=EUR"; AND in app/Traits/ExchangeRateProvidersTrait.php $url = "https://api.apilayer.com/currency_data/live?apikey=".$filter['key']."&source={$baseCurrencyCode}¤cies={$currencyCode}"; $url = "https://api.apilayer.com/currency_data/list?apikey=".$request->key; $url = "https://api.apilayer.com/currency_data/live?apikey=".$request->key."source=INR¤cies=USD";
It would be nice to know how to easily add a new provider. I'm seeing exchange providers in all sorts of JS files, in addition to these 2 files so I'm not sure what do to, but I can always just repurpose one of the existing ones....