crater icon indicating copy to clipboard operation
crater copied to clipboard

Fixing/Adding translations in components, vue, controller

Open agencetwogether opened this issue 1 year ago • 5 comments

Hello, I'm falling in love about this project. 😊 And I would like to contribute by helping in particular to correct untranslated, missing or hard-coded elements.

That's why I made some commits to do this. I hope these commits can help community and that they will be integrated to the next release.

To working properly, I started from version 6.0.6, I tried to correct each local language file in which keys were missing (compared to the English reference version). For each translation carried out, all the language files have been updated.

Of course, each added key will have to be translated into the language concerned

Thanks again for this crazy project

More details about commits :

  • Months below lines in Dashboard and Customers views are now in language defined by locale inside config/app.php
  • Data table is now localized
  • Search bar placeholder and Confirm password label (customers views in admin) are fixed to use translation
  • Add missing keys in ko.json and pt-br.json
  • Add translation for This year and Previous year in drop down above Charts
  • Add news keys in locales files according missing translations for next commits (below this one)
  • Customer portal menu is working now with translations (due to missing option to choose a language in customer settings portal, to be able to have portal in locale, you have to set this on in ressources/scripts/Crater.js)
  • Tooltip to Copy in clipboard works with translations
  • Sign up and get token button working now with translations
  • Limit by and Frequency dropdowns in Recurring invoices are now translated
  • Amount Due below Invoice dropdown in Payment section is now translated
  • Report type dropdown in Reports section is now translated
  • Add translation to BaseFileUploader
  • Add translation to BaseMultiselect
  • Add translation to BaseDatePicker
  • Add news keys in locales files according missing translations for next commits (below this one)
  • Translations everything about Estimates (Admin and Customer portal) using locale
  • Translations everything about Invoices (Admin and Customer portal) using locale
  • Translations everything about Recurring invoices (Admin and Customer portal) using locale
  • Translation for Type dropdown in Note Modal
  • Remove some hardcoded texts by replacing them to locale
  • Improve stats in Dashboards (Admin and Customer portal) with singular/plural (see locale files)
  • Remove some hardcoded texts for Payments by replacing them to locale

agencetwogether avatar Aug 23 '22 00:08 agencetwogether

That's awesome! How can I test the changes on my website?

caiodigioia avatar Sep 12 '22 20:09 caiodigioia

That's awesome! How can I test the changes on my website?

Until these fixes are incorporated in a future version, you can add the changes to your files if you wish, and republish the assets with yarn build command

agencetwogether avatar Sep 13 '22 08:09 agencetwogether

This PR is really well done.

Thanks for the contribution @agencetwogether

So far it's looking really good but I still need to test this a bit more before merging it. I'll update here by weekend 👍

mohitpanjwani avatar Sep 13 '22 09:09 mohitpanjwani

@agencetwogether huge thanks for this effort!!!!

azaricstefan avatar Sep 18 '22 20:09 azaricstefan

@mohitpanjwani , @agencetwogether I tested the translations. This is still a bug #1041.

This file footer could also be translated: "resources/views/vendor/mail/text/message.blade.php"

azaricstefan avatar Sep 18 '22 21:09 azaricstefan

Bump! Can we get this merged?

thalesog avatar Mar 02 '23 00:03 thalesog

@mohitpanjwani @agencetwogether bump ++

azaricstefan avatar Mar 05 '23 02:03 azaricstefan