cratedb-prometheus-adapter icon indicating copy to clipboard operation
cratedb-prometheus-adapter copied to clipboard

Regular expressions not working

Open MaartenMol opened this issue 6 years ago • 1 comments

When running a query in Grafana with expressions like: name=~"test|123" no data is shown.

I don't know if this is normal or a bug?

MaartenMol avatar Nov 22 '18 16:11 MaartenMol

Hi @MaartenMol, can you please provide more insights for this request? I.e. what CrateDB version and setup, which Prometheus and grafana versions and setup you are using? What is the data you ingest from Prometheus and what is the schema in CrateDB you want to query?

ghost avatar Jan 29 '19 07:01 ghost

Dear Maarten,

apologies for replying so late. The whole ecosystem has advanced since you've created this issue, so I am assuming this is not an issue anymore, and it will be safe to close this. Please let me know how to reproduce the error otherwise, and I will be happy to look into it.

With kind regards, Andreas.

amotl avatar Jan 17 '23 20:01 amotl

Dear Maarten,

hi again about this topic, and a happy new year. Even if you might no longer be interested (please tell us), we wanted to tell you that version 0.5.0 has been released today, and we are just now looking at your report again.

On this matter, we can only discover a225ebb28 and GH-27 making changes to the relevant code. By implementing prompb.LabelMatcher_RE and prompb.LabelMatcher_NRE, we think regular expressions should work in general.

Maybe it is specific to your expression, which includes the OR operator in form of the pipe symbol |?

With kind regards, Andreas.

amotl avatar Jan 13 '24 01:01 amotl

Hi again,

we added corresponding integration tests to verify a few variants of query expressions, and haven't been able to observe any problems so far.

  • GH-115

Thus, I am closing this. Please feel free to re-open if you think the flaw is still there.

With kind regards, Andreas.

/cc @WalBeh, @SStorm

amotl avatar Jan 17 '24 00:01 amotl