crate icon indicating copy to clipboard operation
crate copied to clipboard

WIP: Enable TCP fallback for SRV DNS seed lookups

Open seut opened this issue 9 months ago • 2 comments

According to the netty docs, TCP fallback is only enabled when setting a socket channel factory. @mfussenegger Any idea how we could test this?

Closes #17148.

seut avatar Mar 13 '25 08:03 seut

@mfussenegger Any idea how we could test this?

The DNSServer used in https://github.com/crate/crate/blob/79ff2217dde45d6a748b0f31b36c95a7b252878c/blackbox/test_dns_discovery.py#L47 would support a tcp=True option

mfussenegger avatar Mar 17 '25 09:03 mfussenegger

@mfussenegger Any idea how we could test this?

The DNSServer used in

https://github.com/crate/crate/blob/79ff2217dde45d6a748b0f31b36c95a7b252878c/blackbox/test_dns_discovery.py#L47 would support a tcp=True option

Nice, thx!

seut avatar Mar 17 '25 16:03 seut

@mfussenegger I've partly dropped the second commit, just keeping the test changes. Additionally I've increased the default timeout to 10 as suggested. Please re-check.

seut avatar Oct 23 '25 14:10 seut