Followup: Return TIMESTAMP columns as native Python datetime objects

Open amotl opened this issue 3 years ago • 0 comments

Dear @Aymaru,

apologies for the late reply.

On the patch you submitted at #395 the other day, I recently exercised #426 separately. Your other improvements from there have been converged into this very patch, which has been slightly cleaned up to reflect the changes without the gist of #426 and other spurious commits introduced by merging from the master branch.

I've tried to keep your original commits for now, but I might finally squash them together while working on the patch. The next steps are rebasing upon master and adding eventual fixup commits.

Feel free to also add additional comments or suggestions, specifically if you can spot a place where I missed to reflect the improvements from your original patch #395 correctly.

With kind regards, Andreas.

Backlog

[ ] Also convert timestamps within ARRAYs. -- https://github.com/crate/crate-python/pull/437#discussion_r930822457
[ ] Enable this functionality only with a feature flag.

Jul 18 '22 13:07 amotl