crate-dbal icon indicating copy to clipboard operation
crate-dbal copied to clipboard

[DRAFT] Add support for Doctrine 3

Open amotl opened this issue 2 years ago • 4 comments

What the title says.

amotl avatar Nov 24 '22 19:11 amotl

Other than many deprecation warnings, because https://github.com/crate/crate-pdo/pull/146 has not been merged and released yet, running the tests here [^1] raise this fatal error [^2]:

Fatal error: Declaration of Crate\PDO\PDO::prepare($statement, $options = null) must be compatible
with Doctrine\DBAL\Driver\Connection::prepare(string $sql): Doctrine\DBAL\Driver\Statement
in /path/to/crate-dbal/vendor/crate/crate-pdo/src/Crate/PDO/PDO.php on line 193

[^1]: composer run test [^2]: https://github.com/crate/crate-dbal/actions/runs/4895679362/jobs/8741560882?pr=122#step:8:18

amotl avatar May 05 '23 16:05 amotl

It will make no sense to continue working on this before https://github.com/crate/crate-pdo/pull/146 has been merged. Otherwise, there are too many type errors to work around.

In other words, fa8ef492dea0fc0 should be removed again.

amotl avatar May 05 '23 17:05 amotl

Hi @amotl I came across this and was wondering if this will be merge soon now that PR holding you back is merged?

ricohumme avatar Apr 12 '24 13:04 ricohumme

Dear Rico,

thank you for writing in. I am not sure if this patch in its current state is enough to add support for Doctrine 3. Is it?

now that PR holding you back is merged?

because https://github.com/crate/crate-pdo/pull/146 has not been merged and released yet -- https://github.com/crate/crate-dbal/pull/122#issuecomment-1536527654

Ah, I see. Yeah, this would probably need a refresh. Thanks for the reminder!

With kind regards, Andreas.

amotl avatar Apr 13 '24 22:04 amotl