activerecord-crate-adapter icon indicating copy to clipboard operation
activerecord-crate-adapter copied to clipboard

Published 20 hours ago • verified publisher icon crate

Improve robustness of `CrateAdapter::columns` method

Open amotl opened this issue 2 years ago • 0 comments

https://github.com/crate/activerecord-crate-adapter/blob/e875d7ac583773f5857aaa425fe5f1c4aa17cb1c/lib/active_record/connection_adapters/crate_adapter.rb#L132-L138

This feels a bit fishy, see also CrateRuby::Client::table_structure, where select * from information_schema.columns is used, which, when used in combination, is prone to break sooner than later.

Originally posted by @amotl in https://github.com/crate/activerecord-crate-adapter/pull/16#discussion_r1034807861

amotl avatar Nov 30 '22 10:11 amotl