gdx-vfx icon indicating copy to clipboard operation
gdx-vfx copied to clipboard

Missleading method names after refactor in sources

Open dzikoysk opened this issue 4 years ago • 1 comments

Some methods has been renamed in 0.5: https://github.com/crashinvaders/gdx-vfx/blob/4d694a0090f04dfa36348b0dbeba34e81c6753f7/CHANGES.md#050

  • VfxManager's #beginCapture()/#endCapture() have been renamed to #beginInputCapture()/#endInputCapture().

But there is a couple of references to the old ones (I've checked only endCapture), e.g.:

  • https://github.com/crashinvaders/gdx-vfx/blob/6ef5f92b17e1d0b9827b69596234dde119df80c4/gdx-vfx/core/src/com/crashinvaders/vfx/VfxManager.java#L266
  • https://github.com/crashinvaders/gdx-vfx/blob/6ef5f92b17e1d0b9827b69596234dde119df80c4/gdx-vfx/core/src/com/crashinvaders/vfx/VfxManager.java#L313
  • https://github.com/crashinvaders/gdx-vfx/blob/6ef5f92b17e1d0b9827b69596234dde119df80c4/gdx-vfx/core/src/com/crashinvaders/vfx/VfxManager.java#L324
  • https://github.com/crashinvaders/gdx-vfx/blob/6ef5f92b17e1d0b9827b69596234dde119df80c4/gdx-vfx/core/src/com/crashinvaders/vfx/VfxManager.java#L335

dzikoysk avatar Sep 14 '20 14:09 dzikoysk

A nice find, thanks! Will fix it for the next version.

metaphore avatar Sep 14 '20 14:09 metaphore