crasbe
crasbe
> The two holy words everyone wants to hear, ty 🥳 "Changes Requested", yeah you can have that too 😈
The Xiao-ESP32S3 arrived today and I gave it a quick test with some tests: The `tests/periph/adc` test shows the correct values when the pins are pulled up or down. As...
> As with the Xiao-ESP32C3, sometimes some data is lost, but that's most likely not caused by this PR. Indeed, this was caused by USBipd. On my Linux ThinkPad, the...
Replaced by #21829.
Please also check the Doxygen warnings/errors from the Static Test. Now that the Doxygen headers are included, Doxygen actually evaluates many of the headers which previously weren't.
`fix: one day I will not have whitespace errors` You can also run the static tests locally, you know? :D With `make static-test` in the base directory.
You could (temporarily) add the `rpi-pico-2` to the Quickbuild-Boards, similar to this commit: https://github.com/RIOT-OS/RIOT/pull/21590/commits/6d2ec699c212a77a385d51d0184ce03e6eb8006e Currently CI does not actually build the quickbuild-applications for the RP2350 I think.
If you want to, you can also squash the comments down a bit. Just make sure not to accidentally squash in stuff you don't want to keep 😅
You can rebase this now :)
Some of the files have the wrong indentation width (two spaces instead of four). I think VS Code can automagically fix that for you.