Craig de Stigter

Results 70 comments of Craig de Stigter
trafficstars

the mypy stuff is also blowing my mind a bit to be honest. I just spent about an hour trying to resolve all the type warnings and haven't yet managed...

The original data we found this in came from a bigger dataset. Running it on cchardet 1.1.3 and 2.0 gives quite different results: ``` # cchardet 1.1.3 $ ./cchardet-detect.py data.csv...

Thanks @skim618 for finishing this off

yes, looks like moto dropped 3.7 support: https://github.com/getmoto/moto/commit/2fd5e800e4aab49a69856fa71bccf898d541a64a I've fixed the tests by undoing my previous moto upgrade and instead pinning to

are those gcloud failures expected? I also get them locally. Seems unrelated to the changes in this PR though

that makes sense, thanks. Is it possible to build it without static linking? I looked for docs on this but didn't find much yet. I'm not a JS native so...

I noticed something similar in a failing test in our app just now when upgrading from django-filter 23.2 to 23.3 - a callable `choices` on a `ChoiceFilter` (which wasn't used...

Fair enough. Maybe just suggesting (and generating) config files with a .py extension would be enough. Makes it really clear it's a python file and not some kind of INI...

Thanks for your reply. This is the default behaviour of text-mode files in Python: https://docs.python.org/3/library/functions.html#open > newline determines how to parse newline characters from the stream. It can be None,...

any chance of a review here?