karma-gradle icon indicating copy to clipboard operation
karma-gradle copied to clipboard

karmaRefresh cleaning entire node_modules folder

Open borgiani opened this issue 7 years ago • 4 comments

Hi, when running the karmaRefresh task (which depends on karmaClean), the entire node_modules folder is being cleaned. This is not very efficient in CI environments, because it causes the CI system to have to reload all node modules on every build. By looking at the code, it seems the issue could be caused by: https://github.com/craigburke/karma-gradle/blob/master/src/main/groovy/com/craigburke/gradle/KarmaPlugin.groovy#L98

I'm guessing that replacing it with file should fix it.

Thanks!

borgiani avatar Jun 09 '17 18:06 borgiani

Suggested fix: #32 Have you had the chance to review this @craigburke ?

borgiani avatar Aug 10 '17 14:08 borgiani

@craigburke Adding this fix would be greatly appreciated! I have other libraries in my project, and it takes forever to do a fresh build because of this issue.

drschulz avatar Oct 11 '17 17:10 drschulz

+1

asoftwareguy avatar Dec 13 '17 20:12 asoftwareguy

@craigburke any chance you may have a look at this?

borgiani avatar Feb 05 '18 19:02 borgiani