Craig Box
Craig Box
(You might also like to check your current advisor, as I think it's a little out of date) (The current ChatGPT does a bit better, though doesn't get it entirely...
Hi @Andygol, This clearly represents a _lot_ of work and is a very large contribution. **Thank you!** As @dhawton has said, we are not qualified to review it. My only...
I'm pretty happy with A and B, and if you're willing to help us with something with regard to C, I think we are good to go. I will put...
We still need to arrange some way to review this, and then we can progress.
Be aware there will be some changes - at least one on the front page - that we'll want to be updated quickly when 1.24 lands in a day or...
https://github.com/istio/istio.io/pull/15700#issuecomment-2361117293 reflects the actual problem
The eventual cause of the error is `strip_indent.html`. The partial gets the input: ``` $ kubectl apply -f - <<EOF apiVersion: networking.istio.io/v1 kind: VirtualService metadata: name: httpbin spec: hosts: -...
Great initiative. The new modules would need to be in the build container before the lint will pass. I don't have enough context to say yes or no without doing...
https://github.com/istio/tools/pull/3222 LGTM but I'm not in the reviewer set. Daniel is, so I think that will go through today his time.
I think it's reasonable for a build to clean up any temporary files after using them? However the `entrypoint.js` file should not contain reference to tmp files that aren't normally...