MonoGame.Extended icon indicating copy to clipboard operation
MonoGame.Extended copied to clipboard

What is "UIBatcher" in Batcher2D.cs's class comment ?

Open Dante3085 opened this issue 4 years ago • 3 comments

The class comment of Batcher2D.cs mentions a UIBatcher for drawing user interfaces. I am interested in that but can't find anything like that in this repository.

/// <summary>
    ///     A general purpose <see cref="Batcher{TDrawCallInfo}" /> for two-dimensional geometry that change
    ///     frequently between frames such as sprites and shapes.
    /// </summary>
    /// <seealso cref="IDisposable" />
    /// <remarks>
    ///     <para>For drawing user interfaces, consider using <see cref="UIBatcher(ref Matrix, ref Matrix, BlendState, SamplerState, DepthStencilState, RasterizerState, Effect)" /> instead because it supports scissor rectangles.</para>
    /// </remarks>

Dante3085 avatar Aug 18 '20 16:08 Dante3085

Hello @Dante3085

Nice catch. This is a great example of how comments (including the XML Docs) can become out of sync with the code. I'll admit I'm pretty sure I wrote that XML Doc when I didn't know better. This comment is specifically more about me talking to myself; it should have never really been committed.

The idea for the UIBatcher fell short in the end. Turns out that for games, using sprites is just fine for most UI needs.

lithiumtoast avatar Aug 18 '20 21:08 lithiumtoast

Hi @lithiumtoast

Thank you for the reply! Should I leave the issue open for when you fix the comment?

Dante3085 avatar Aug 19 '20 10:08 Dante3085

Yes, I'll close it when the comment is removed.

lithiumtoast avatar Aug 19 '20 13:08 lithiumtoast