feed-me icon indicating copy to clipboard operation
feed-me copied to clipboard

Batched feed processing causes feed events to fire per batch

Open pixelmachine opened this issue 9 months ago • 3 comments

Description

The following events all fire per batch which I don't believe is correct based on @i-just's comment here which states that the beforeProcessFeed() method only runs once if there's no pagination:

  • beforeFetchFeed
  • afterFetchFeed
  • afterParseFeed
  • beforeProcessFeed

This event still only fires once:

  • afterProcessFeed

There are currently no feed events that fire only once per feed run which makes it hard to do basic preflight functions. I haven't tested what happens on a per page basis as my data is all single page.

Additional info

  • Craft version: 5.6.14
  • PHP version: 6.8.0

pixelmachine avatar Apr 03 '25 03:04 pixelmachine

I think we have a similar issue here.

In our case the Blitz Cache plugin is installed. After every batch the feed me import process get's killed and the blitz plugin starts caching the sites (which are a lot).

Image

Image

Can we somehow workaround this issue for now, since we regularly need this import?

ammannbe avatar Apr 03 '25 11:04 ammannbe

@ammannbe I'm going to downgrade to 6.7.0

pixelmachine avatar Apr 03 '25 23:04 pixelmachine

Hi, thanks for reporting! I raised a PR to adjust this.

i-just avatar Apr 10 '25 12:04 i-just

Resolved in https://github.com/craftcms/feed-me/pull/1628 and is included in the 5.12.0 and 6.9.0 releases!

angrybrad avatar Aug 11 '25 04:08 angrybrad