feed-me icon indicating copy to clipboard operation
feed-me copied to clipboard

Published 20 hours ago • verified publisher icon craftcms

Issue with tables for Commerce Variants

Open CharlieGentle opened this issue 3 years ago • 3 comments

Hi, I'm trying to add support for Feed Me to a custom field type in a plugin. It works ok when added to Entries and Products but when I move it to a Variant it stops working. In trying to debug this I think I've found it shares the same issue as Table field types do on Variants. The _parseVariants function fails to parse the table columns and doesn't get fields from $fieldInfo.

Steps to reproduce

  1. Create Commerce Product with variants
  2. Add table filed type to the variants
  3. Create feed and map data to the table field
  4. Run feed, variants will not be updated with the mapped data.

Additional info

  • Craft version: 4.1.0.2
  • PHP version: 8.0.20
  • Plugins & versions: Feed Me 5.0.4, Craft Commerce 4.0.4

CharlieGentle avatar Jul 12 '22 13:07 CharlieGentle

Any updates on this?

samuelbirch avatar Aug 08 '22 13:08 samuelbirch

Pull request submitted to fix this issue.

CharlieGentle avatar Aug 23 '22 15:08 CharlieGentle

+1 to this issue, it is a major issue with an upcoming critical data import

@angrybrad do you have any time to have a look at this?

robzor avatar Aug 24 '22 14:08 robzor

+1 also

Similar related issue posted 2 years ago with solution https://github.com/craftcms/feed-me/issues/464

bymayo avatar Nov 29 '22 15:11 bymayo

Resolved for the next v4 and v5 releases via https://github.com/craftcms/feed-me/pull/1268

angrybrad avatar Apr 06 '23 00:04 angrybrad