feed-me icon indicating copy to clipboard operation
feed-me copied to clipboard

#797 making empty strings able to overwrite previous values

Open floatingbits opened this issue 3 years ago • 8 comments

Description

Treating empty string as legal value that can overwrite current values and will not be ignored in further processing.

Related issues

#797

floatingbits avatar Dec 08 '21 09:12 floatingbits

@floatingbits Could you please take a look at this? It seems like a solution for several of our clients as well...

boudewijn-zicht avatar Jun 15 '22 15:06 boudewijn-zicht

@boudewijn-zicht I think you wanted to mention @angrybrad. He's the reviewer. I'm just a random developer who suggested a fix ;)

floatingbits avatar Jun 22 '22 14:06 floatingbits

Very good point :smile:

Let me try that again...

@angrybrad Could you please take a look at this? It seems like a solution for several of our clients as well...

boudewijn-zicht avatar Jun 23 '22 07:06 boudewijn-zicht

@boudewijn-zicht yup, have a tab open to look at this, but it'll probably be next week.

angrybrad avatar Jun 23 '22 21:06 angrybrad

@boudewijn-zicht yup, have a tab open to look at this, but it'll probably be next week.

Awesome, that makes me very happy!

boudewijn-zicht avatar Jun 24 '22 08:06 boudewijn-zicht

@boudewijn-zicht yup, have a tab open to look at this, but it'll probably be next week.

hi braid. this issue still hasn't been resolved. could you please look into this?

mdoorschodt avatar Nov 15 '22 08:11 mdoorschodt

hi @angrybrad, could you give us an update please? ik would be so nice if this could be resolved... i've got several clients with feeds that we can't process properly due to this issue

mdoorschodt avatar Jan 12 '23 15:01 mdoorschodt

This might have been fixed in 5.1.0:

Added the “Set Empty Values” feed setting, which determines whether empty values in the feed should be respected or ignored. (https://github.com/craftcms/feed-me/pull/1228, https://github.com/craftcms/feed-me/issues/797, https://github.com/craftcms/feed-me/issues/723, https://github.com/craftcms/feed-me/issues/854, https://github.com/craftcms/feed-me/issues/680)

Source: https://github.com/craftcms/feed-me/blob/develop/CHANGELOG.md#510---2023-03-17

tricki avatar Dec 05 '23 17:12 tricki