docker icon indicating copy to clipboard operation
docker copied to clipboard

Add craft server check

Open timkelty opened this issue 3 years ago • 1 comments

Note: I'm intentionally running the server check after the runtime-deps/cleanup stuff, as if our runtime-deps don't end up installed properly, we want the check to fail.

timkelty avatar Aug 18 '21 15:08 timkelty

Same here! Nice work!!

jasonmccallister avatar Aug 19 '21 02:08 jasonmccallister

This is part of the new image build process, going to mark this as closed https://github.com/craftcms/image/blob/8.3/Dockerfile#L93

jasonmccallister avatar Apr 18 '24 13:04 jasonmccallister

@jasonmccallister you know, you could add an extra test stage in the Dockerfile which you would target in the pipeline build or test job or some docker run --rm ... curl ... step. This would help to keep the number of layers low 😉

PS: there are again a lot of RUN steps, which could be merged together like some mkdir or touch or even chown -R commands 🤔

PPS: i am beginning to doubt whether i have misunderstood the concepts here. @jasonmccallister could you explain to me why you are writing the Dockerfiles that way?

jawys avatar Apr 18 '24 13:04 jawys