docker
docker copied to clipboard
Add craft server check
Note: I'm intentionally running the server check after the runtime-deps/cleanup stuff, as if our runtime-deps don't end up installed properly, we want the check to fail.
Same here! Nice work!!
This is part of the new image build process, going to mark this as closed https://github.com/craftcms/image/blob/8.3/Dockerfile#L93
@jasonmccallister you know, you could add an extra test stage in the Dockerfile which you would target in the pipeline build or test job or some docker run --rm ... curl ...
step.
This would help to keep the number of layers low 😉
PS: there are again a lot of RUN steps, which could be merged together like some mkdir
or touch
or even chown -R
commands 🤔
PPS: i am beginning to doubt whether i have misunderstood the concepts here. @jasonmccallister could you explain to me why you are writing the Dockerfiles that way?