aws-s3 icon indicating copy to clipboard operation
aws-s3 copied to clipboard

Base URL is overwritten on bucket input blur

Open timkelty opened this issue 5 years ago • 2 comments

It tries to infer the base url, but it should really only do this if that field is empty.

Screencast: https://drive.google.com/file/d/10Te4cS53NojIQDyXEKO1i36nhNR_wS8d/view

timkelty avatar Aug 24 '20 15:08 timkelty

As a corollary to this, if the bucket name is set to an environment variable, say $S3_BUCKET_NAME, then the auto-generated Base URL gets written as https://s3.[region].amazonaws.com/$S3_BUCKET_NAME/ and used as a literal string without the bucket name being interpolated into the Base URL. This causes requests such as this to appear in the browser:

GET https://s3.us-east-2.amazonaws/$S3_BUCKET_NAME/assets/images/globals/logo.png

...which clearly won't work. 😞

beporter avatar Oct 08 '20 21:10 beporter

This is still an issue.

ccchapman avatar Jan 12 '23 17:01 ccchapman