remixavier icon indicating copy to clipboard operation
remixavier copied to clipboard

Update for qt5, librosa >= 0.10 (but really 0.6)

Open bmcfee opened this issue 1 year ago • 4 comments

:wave: had a student with a use for this tool recently, and found that it no longer works on a modern stack. I've taken a stab at updating things here as described: qt5 and recent-ish librosa.

On the librosa side, changes are as follows:

  • kwarg requirements
  • logamplitude -> amplitude_to_db
  • the removal of the output module (in favor of soundfile).

I've also added a simple requirements.txt file.

I haven't updated the experiments script, but at least this gets the gui tool running again.

bmcfee avatar Oct 02 '24 14:10 bmcfee

If this is ready to go I can merge, LMK.

craffel avatar Oct 12 '24 01:10 craffel

@bmcfee can you take a look at the requested changes and and then I can merge?

craffel avatar Nov 29 '24 21:11 craffel

@bmcfee can you take a look at the requested changes and and then I can merge?

I may be having some kind of brain meltdown here, but I don't see how to do that?

bmcfee avatar Dec 02 '24 20:12 bmcfee

Huh, that is a good question - when I hit "View requested changes" next to " edgeofeverywhere suggested changes 5 days ago" I also don't see any requested changes. @edgeofeverywhere you mentioned "the changes I made here" - where are those changes? Can you put them on a fork or something?

craffel avatar Dec 04 '24 02:12 craffel