eegUtils icon indicating copy to clipboard operation
eegUtils copied to clipboard

Suggestion: add docs for the various S3 classes

Open mattansb opened this issue 4 years ago • 5 comments

In order to expand on eegUtils, it would make it super helpful to understand what the various objects can be expected to hold (:

mattansb avatar Jun 10 '21 08:06 mattansb

https://craddm.github.io/eegUtils/articles/data_structures.html has some info on these lines - I'll improve/update it Soon™

craddm avatar Jun 10 '21 09:06 craddm

Ohhhhhh I missed that because I was looking in the function list 😅 oops!

mattansb avatar Jun 10 '21 10:06 mattansb

It could definitely be better so that's still going on the list!

craddm avatar Jun 10 '21 10:06 craddm

Is there a reason that only for the eeg_tfr class the signals slot is an array (vs a (timeXepochs)Xchannels data frame)? I assume an array would be more memory efficient? (cf. {cubelyr})

mattansb avatar Jun 17 '21 17:06 mattansb

With eeg_tfr it made much more sense to do the transformations in an array internally, and then it ended up being easier to interact with if it stays an array. If I could start over then I'd probably just use arrays for everything, but I didn't really expect to go so far with it all... I did start another test package that was for switching current formats to arrays. But memory-wise tbh it hardly seems to make much difference when I've tried testing it all, and I haven't the time to rewrite everything and ensure backward compatibility etc

craddm avatar Jun 18 '21 08:06 craddm