Print.js icon indicating copy to clipboard operation
Print.js copied to clipboard

Published 20 hours ago • verified publisher icon crabbly

avoid blank page on safari and firefox

Open acapellacci opened this issue 1 year ago • 4 comments

Blank page issue still occurs with Firefox v114 and Safari. For this reason I propose to add a delay for both browsers and all versions.

acapellacci avatar Jul 04 '23 11:07 acapellacci

Hi @crabbly Could you please take a look on this PR? It resolves the issue mentioned here: #528

Thanks @crabbly @acapellacci

fs-nathan avatar Jul 13 '23 07:07 fs-nathan

@acapellacci The most recent version of Print.js has not yet been published, unfortunately, so the chances are that the master branch actually works with Firefox v114?

Do you have the issue with Firefox v114 using print-js-updated https://github.com/crabbly/Print.js/issues/665#issuecomment-1597107088 ?

amoilanen avatar Jul 26 '23 13:07 amoilanen

@acapellacci

At least it was proven in the past that Firefox 110.0 does not work with the added timeout, so this PR might inadvertently reintroduce https://github.com/crabbly/Print.js/issues/665 for Firefox 110.0 ?

If the timeout is needed for more recent versions of Firefox (114) and for some earlier versions (110.0) it should be removed, the condition should probably be still kept and needs to be more specific about the Firefox version?

amoilanen avatar Jul 26 '23 13:07 amoilanen

@acapellacci

At least it was proven in the past that Firefox 110.0 does not work with the added timeout, so this PR might inadvertently reintroduce #665 for Firefox 110.0 ?

If the timeout is needed for more recent versions of Firefox (114) and for some earlier versions (110.0) it should be removed, the condition should probably be still kept and needs to be more specific about the Firefox version?

The issue occures in Safari 16.6 and Firefox 115

acapellacci avatar Jul 28 '23 12:07 acapellacci