Print.js icon indicating copy to clipboard operation
Print.js copied to clipboard

Fixing #582 and #572

Open PauloPeres opened this issue 3 years ago • 4 comments

With this pull request I'm Fixing Issue #582 and #572 Also it's a improvement from the PR #566

Added another parameter frameRemoveDelay Default value is Null so it will not change to anyone else. But when it's needed is there to add a little bit more time to print when using silent printing --kiosk-printing on Chromium based browsers.

Added a testing button and did the test my self using 1000ms and it worked.

PauloPeres avatar Jul 31 '21 14:07 PauloPeres

please, merge this PR

kimaguri avatar Oct 11 '21 10:10 kimaguri

Whoever is waiting for this PR you can use "print-js": "git+https://github.com/PauloPeres/Print.js.git#production", on your Package json, replacing the print-js for this github repo

PauloPeres avatar Oct 11 '21 12:10 PauloPeres

any new update about this pr

stoufax avatar May 17 '22 15:05 stoufax

@crabbly Can this be pulled please?

joeknex avatar Oct 03 '22 10:10 joeknex

Can a New Release be published on NPM ?

PauloPeres avatar Feb 27 '23 12:02 PauloPeres

I too am waiting for the release of a new version in npm! @crabbly

yoshiko-pg avatar Mar 17 '23 09:03 yoshiko-pg

@crabbly Is there something wrong with releasing a new version to npm?

yoshiko-pg avatar Nov 07 '23 07:11 yoshiko-pg