Print.js icon indicating copy to clipboard operation
Print.js copied to clipboard
verified publisher icon crabbly

fix: added globalObject: 'this' to fix ssr warning for window in umd dist definition

Open daphnesmit opened this issue 4 years ago • 2 comments

fixes #542 I hope this fixes it according to https://zenuml.medium.com/window-is-undefined-in-umd-library-output-for-webpack4-858af1b881df

SSR issue appears for example in NextJS

Anybody looking here for a fix. I ported library (everything except the Modal functionality, because thats UI IMHO): (I am planning to rewrite to Typescript. Make pr's I will check and merge!) https://www.npmjs.com/package/prntr

daphnesmit avatar Mar 01 '21 13:03 daphnesmit

Pull Request Test Coverage Report for Build 342

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 48.241%
Totals Coverage Status
Change from base Build 341: 0.0%
Covered Lines: 239
Relevant Lines: 363
💛 - Coveralls

coveralls avatar Mar 01 '21 13:03 coveralls

WHO WILL EVER MERGE THIS PRETTY PLEASE! @crabbly

daphnesmit avatar Jul 15 '21 10:07 daphnesmit